Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

SQL Server Artifact missing Fix #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

taylor-j-hawkins
Copy link

@taylor-j-hawkins taylor-j-hawkins commented Aug 15, 2017

Resolves the issues with the SQLServer Artifact function.
It's currently functional for cases with one SQLServer instance, but needs to be tested for cases where there are multiple SQLServer instances.

The reason for this pull request is documented in this issue:

"https://github.com/docker/communitytools-image2docker-win/issues/57"

Seems to work for VHD's with one SQL Server instance, needs to be tested with multiple SQL Server instances.
@WinniX
Copy link

WinniX commented Sep 13, 2017

Hi @Marashni
Do you know when this fix will be delivered?

@sixeyed
Copy link
Contributor

sixeyed commented Sep 13, 2017

Thanks for this @Marashni. @WinniX it's on-hold at the moment because recognizing SQL Server is only part of the workflow. The tool also needs to generate output from the source SQL database - and we're looking at options - e.g. should it extract the MDF file(s), or be more intelligent and extract just the schema.

@taylor-j-hawkins
Copy link
Author

Hi @WinniX, this just fixes what the code was trying to do as it was written. However, as @sixeyed noted even with the fix to the code, it doesn't really do much except capture instance names. Functionality for pulling MDF's or schema has yet to be implemented.

@qJake
Copy link

qJake commented Oct 3, 2017

This was advertised at Microsoft Ignite as working (being able to pull a live SQL Server database and convert it into a container image) during this session: https://myignite.microsoft.com/sessions/53257?source=sessions

Is that not true, does this functionality not exist yet?

@taylor-j-hawkins
Copy link
Author

The last I was aware the code didn't really do anything. I submitted a pull request to fix the code as it was written to do what the code seemed to intend, which was to pull instance names out of a registry hive on your VM's .VHDX, and that's all it really does, last I knew.

That sounds like false advertising, but it's not the first I've seen regarding this tool. @sixeyed probably knows more about the team's internal plans to implement the described functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants